lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 08 May 2013 10:24:44 +0800 From: Chen Gang <gang.chen@...anux.com> To: Arnd Bergmann <arnd@...db.de> CC: Greg KH <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org >> \"linux-kernel@...r.kernel.org\"" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] Drivers: Misc: fix warnings, unsigned long will never < 0 Hello Maintainers: Please help check, when you have time. Thanks. On 2013年04月07日 11:28, Chen Gang wrote: > > val is unsigned long which never < 0 > > Signed-off-by: Chen Gang <gang.chen@...anux.com> > --- > drivers/misc/tsl2550.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c > index 1e7bc0e..5bf9448 100644 > --- a/drivers/misc/tsl2550.c > +++ b/drivers/misc/tsl2550.c > @@ -204,7 +204,7 @@ static ssize_t tsl2550_store_power_state(struct device *dev, > unsigned long val = simple_strtoul(buf, NULL, 10); > int ret; > > - if (val < 0 || val > 1) > + if (val > 1) > return -EINVAL; > > mutex_lock(&data->update_lock); > @@ -236,7 +236,7 @@ static ssize_t tsl2550_store_operating_mode(struct device *dev, > unsigned long val = simple_strtoul(buf, NULL, 10); > int ret; > > - if (val < 0 || val > 1) > + if (val > 1) > return -EINVAL; > > if (data->power_state == 0) > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists