linux-kernel - Re: [PATCH] kernel/module.c: for looping, need use 'goto' instead of 'break' to jump out in time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 May 2013 09:59:06 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/module.c: for looping, need use 'goto' instead of 'break' to jump out in time

Chen Gang <gang.chen@...anux.com> writes:
> In the 'for' looping, when error occurs, the 'break' only jump out of
> 'switch', and still in 'for' looping.  If error occurs multiple times,
> the original error value will be overwrite.
>
> Currently, that will not cause issue, but still better to improve it,
> so that let it return the first real error code in time.

We choose to print all the problems, rather than just one.  I don't
really mind though.

It we want this patch, it would be neater to just 'return -ENOEXEC'
and 'return PTR_ERR(ksym) ?: -ENOENT'.

Cheers,
Rusty.

> The related commit: "1da177e Linux-2.6.12-rc"
>
>
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  kernel/module.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index b049939..7e012ff 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1977,7 +1977,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
>  			printk("%s: please compile with -fno-common\n",
>  			       mod->name);
>  			ret = -ENOEXEC;
> -			break;
> +			goto tail;
>  
>  		case SHN_ABS:
>  			/* Don't need to do anything */
> @@ -2000,7 +2000,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
>  			printk(KERN_WARNING "%s: Unknown symbol %s (err %li)\n",
>  			       mod->name, name, PTR_ERR(ksym));
>  			ret = PTR_ERR(ksym) ?: -ENOENT;
> -			break;
> +			goto tail;
>  
>  		default:
>  			/* Divert to percpu allocation if a percpu var. */
> @@ -2013,6 +2013,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
>  		}
>  	}
>  
> +tail:
>  	return ret;
>  }
>  
> -- 
> 1.7.7.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/