linux-kernel - RE: WARNING at drivers/pci/search.c:214 for 3.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 May 2013 17:22:24 +0000
From:	"Ortiz, Lance E" <lance.oritz@...com>
To:	Borislav Petkov <bp@...en8.de>
CC:	Bruno Prémont <bonbons@...ux-vserver.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-ACPI <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Tony Luck <tony.luck@...el.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"Dall, Elizabeth J (MCLinux)" <betty.dall@...com>
Subject: RE: WARNING at drivers/pci/search.c:214 for 3.9

> > The only reason we are calling pci_get_domain_bus_and_slot() is to
> get
> > the pci_dev* to pass into cper_print_aer() so we can have the
> device's
> > name to put into the trace event for AER. If we can find another way
> > to get the device name for the trace event we could remove this call
> > to pci_get_domain_bus_and_slot(). I will continue to look into an
> > alternative. If you have any ideas on how to get the device data from
> > this context let me know.
> 
> Hmm, not sure.
> 
> Off the top of my head, maybe add the whole code around:
> 
> #ifdef CONFIG_ACPI_APEI_PCIEAER
> ...
> 
> #endif
> 
> in cper_print_pcie() into a separate function which is called from a
> workqueue right after the interrupt is done.. Or something to that
> effect.

I am sending out a patch that should fix the warning and remove the call to get_pci* out of interrupt context.  It is called: 

[PATCH] aerdrv: Move cper_print_pcie() out of interrupt context

Please take a look when you get a chance.

Lance