linux-kernel - Re: [PATCH 09/14] perf ftrace: Add 'record' sub-command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 May 2013 14:27:40 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 09/14] perf ftrace: Add 'record' sub-command

Hi Jiri,

On Mon, 6 May 2013 14:04:11 +0200, Jiri Olsa wrote:
> On Mon, May 06, 2013 at 10:44:56AM +0900, Namhyung Kim wrote:
>> Hi Jiri,
>> 
>> Sorry for late reply.  I've been busy these days.
>> 
>> On Thu, 25 Apr 2013 15:24:18 +0900, Namhyung Kim wrote:
>> > But it looks there's a race between cond_wait() and cond_broatcast().
>> > I'll take a look at that.
>> 
>> I think the problem is that a recorder can be blocked if it received a
>> broadcast signal before calling cond_wait().  So I modified the code to
>> place signaling ready_cond and waiting start_cond in the same cs.
>> 
>> Does the patch below fix your problem?
>
> yes.. without the patch I get lockup in like 10 minutes
> with the patch the test is now ok for almost an hour..

Many thanks for your test!

Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/