linux-kernel - Re: [PATCH] perf: detect when perf.data file not closed out properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 May 2013 11:32:53 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...stprotocols.net, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: detect when perf.data file not closed out properly


* David Ahern <dsahern@...il.com> wrote:

> +		pr_err("data size is 0. "
> +		       "Was the record command properly terminated?\n");

Btw., a small stylistic request: please put user-visible strings into a 
single line - even if it technically turns into an overlong line.

		pr_err("data size is 0. Was the record command properly terminated?\n");

This 1) makes it easier for people to git grep the error text they are 
seeing during usage 2) makes it easier for _developers_ to see the 
messages they are outputing to users.

For example from the single-line output it's immediately visible that it 
should be capitalized thusly:

		pr_err("Data size is 0. Was the record command properly terminated?\n");

:-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/