lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 May 2013 10:53:41 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Jiri Olsa <jolsa@...hat.com> Cc: linux-kernel@...r.kernel.org, Corey Ashford <cjashfor@...ux.vnet.ibm.com>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Arnaldo Carvalho de Melo <acme@...hat.com>, Andi Kleen <ak@...ux.intel.com>, David Ahern <dsahern@...il.com>, Stephane Eranian <eranian@...gle.com> Subject: Re: [PATCH 5/9] perf tools: Set maximum precise value for event 'p' modifier On Thu, 9 May 2013 15:32:20 +0200, Jiri Olsa wrote: > If single 'p' modifier is specified for event, set the > system precise value for perf_events_attr::precise_ip. > > If more than a single 'p' is specified keep the intended > value. So there's no way to set precise=1 on a system suppports precise=2 using this syntax, right? (I don't know whether it makes any sense though.) > > If precise is not supported by system, warning is disaplyed. s/disaplyed/displayed/ > > Signed-off-by: Jiri Olsa <jolsa@...hat.com> > Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com> > Cc: Frederic Weisbecker <fweisbec@...il.com> > Cc: Ingo Molnar <mingo@...e.hu> > Cc: Namhyung Kim <namhyung@...nel.org> > Cc: Paul Mackerras <paulus@...ba.org> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com> > Cc: Andi Kleen <ak@...ux.intel.com> > Cc: David Ahern <dsahern@...il.com> > Cc: Stephane Eranian <eranian@...gle.com> > --- > tools/perf/util/parse-events.c | 40 ++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 2e3ef10..6be4599 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -533,6 +533,26 @@ int parse_events_add_breakpoint(struct list_head **list, int *idx, > return add_event(list, idx, &attr, NULL); > } > > +static int precise_default(void) > +{ > + int precise = perf_precise__get(); > + static int warned; > + > + /* > + * Precise info not supported by by this kernel, s/by by/by/ :) > + * set 1 as the precise value. > + */ > + if (precise == -1) > + precise = 1; > + > + /* PEBS is not supported here, display warning. */ > + if (precise == 0 && !warned++) > + pr_warning("warning: no precise support, " > + "using non-precise event(s)\n"); Please put the message on a single line. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists