linux-kernel - RE: linux-next: manual merge of the akpm tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 13 May 2013 01:20:16 -0400 (EDT)
From:	Eric Paris <eparis@...hat.com>
To:	keescook@...omium.org
Cc:	sfr@...b.auug.org.au, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, jlayton@...hat.com,
	viro@...iv.linux.org.uk
Subject: RE: linux-next: manual merge of the akpm tree with Linus' tree


-----Original Message-----
From: Kees Cook [keescook@...omium.org]
Received: Monday, 13 May 2013, 12:49am
To: Eric Paris [eparis@...hat.com]
CC: Stephen Rothwell [sfr@...b.auug.org.au]; Andrew Morton [akpm@...ux-foundation.org]; Linus [torvalds@...ux-foundation.org]; Linux-Next [linux-next@...r.kernel.org]; LKML [linux-kernel@...r.kernel.org]; Jeff Layton [jlayton@...hat.com]; Al Viro [viro@...iv.linux.org.uk]
Subject: Re: linux-next: manual merge of the akpm tree with Linus' tree

On Sun, May 12, 2013 at 7:11 PM, Eric Paris <eparis@...hat.com> wrote:
> On Mon, 2013-05-13 at 12:07 +1000, Stephen Rothwell wrote:
>> Hi Andrew,
>>
>> Today's linux-next merge of the akpm tree got a conflict in
>> kernel/auditsc.c between commit b24a30a73054 ("audit: fix event coverage
>> of AUDIT_ANOM_LINK") from Linus' tree and commit "audit: fix mq_open and
>> mq_unlink to add the MQ root as a hidden parent audit_names record" from
>> the akpm tree.
>
> Actually, I've already picked the patch up for 3.11.  So Andrew, you can
> drop it.
>
>> I fixed it up (see below) and can carry the fix as necessary (no action
>> is required).
>>
>> BTW, commit b24a30a73054 from Linus' tree has Eric Paris as Author and
>> Committer, but is only Signed-off-by Kees Cook.  It is part of a long
>> series that did not go anywhere near linus-next.   I do have an audit
>> tree in linux-next
>> (git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit.git#for-next)
>> but that hasn't seen any recent activity.
>
> I thought I sent you a note asking for audit to get pulled into -next
> quite a while back.  I'll resend...
>

Hrm, how did the Author get mangled?


I remember it having a conflict when I tried to merge it (someone else had changed the same area of the header file). So I used patch -p1 and fixed up the reject by hand. I wonder if I screwed up and used git commit -a instead of git am --resolved?   That is 2 things I should have caught on final review I missed.  :-(

Now to wait for everything else I screwed up...