linux-kernel - [PATCH 3/4] media: usb: remove duplicate checks for EPERM in vidioc_g/s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 May 2013 11:15:16 +0530
From:	Lad Prabhakar <prabhakar.csengg@...il.com>
To:	LMML <linux-media@...r.kernel.org>,
	uclinux-dist-devel@...ckfin.uclinux.org, ivtv-devel@...vdriver.org
Cc:	linux-kernel@...r.kernel.org,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Scott Jiang <scott.jiang.linux@...il.com>,
	Jonathan Corbet <corbet@....net>,
	Andy Walls <awalls@...metrocast.net>,
	Mike Isely <isely@...ox.com>,
	Devin Heitmueller <dheitmueller@...nellabs.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Antti Palosaari <crope@....fi>,
	Jon Arne Jørgensen <jonarne@...arne.no>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Alexey Klimov <klimov.linux@...il.com>,
	Martin Bugge <marbugge@...co.com>,
	Javier Martin <javier.martin@...ta-silicon.com>,
	Frank Schäfer <fschaefer.oss@...glemail.com>,
	Janne Grunau <j@...nau.net>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: [PATCH 3/4] media: usb: remove duplicate checks for EPERM in vidioc_g/s_register

From: Lad, Prabhakar <prabhakar.csengg@...il.com>

This patch removes check for EPERM in vidioc_g/s_register
as this check is already performed by core.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index e11267f..01d1c2d 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -5173,8 +5173,6 @@ int pvr2_hdw_register_access(struct pvr2_hdw *hdw,
 	int stat = 0;
 	int okFl = 0;
 
-	if (!capable(CAP_SYS_ADMIN)) return -EPERM;
-
 	req.match = *match;
 	req.reg = reg_id;
 	if (setFl) req.val = *val_ptr;
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/