linux-kernel - Re: [PATCH] pinctrl/lantiq: Free mapping configs for both pin and groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 12:36:06 +0200
From:	John Crispin <blogic@...nwrt.org>
To:	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl/lantiq: Free mapping configs for both pin and
 groups

On 14/05/13 17:00, Laurent Pinchart wrote:
> When creating mappings from DT both pin config and group config mappings
> are allocated. Free them both when destroying the mappings.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart+renesas@...asonboard.com>
Acked-by: John Crispin <blogic@...nwrt.org>


> ---
>   drivers/pinctrl/pinctrl-lantiq.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-lantiq.c b/drivers/pinctrl/pinctrl-lantiq.c
> index 615c500..d22ca25 100644
> --- a/drivers/pinctrl/pinctrl-lantiq.c
> +++ b/drivers/pinctrl/pinctrl-lantiq.c
> @@ -52,7 +52,8 @@ static void ltq_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
>   	int i;
>
>   	for (i = 0; i<  num_maps; i++)
> -		if (map[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
> +		if (map[i].type == PIN_MAP_TYPE_CONFIGS_PIN ||
> +		    map[i].type == PIN_MAP_TYPE_CONFIGS_GROUP)
>   			kfree(map[i].data.configs.configs);
>   	kfree(map);
>   }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/