linux-kernel - RE: [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver (v2).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 10:22:11 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>, bob.liu@...cle.com,
	dan.magenheimer@...cle.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	xen-devel@...ts.xensource.com
Subject: RE: [PATCH] Fixes, cleanups, compile warning fixes, and documentation
 update for Xen tmem driver (v2).

> From: Konrad Rzeszutek [mailto:ketuzsezr@...il.com] On Behalf Of Konrad Rzeszutek Wilk
> Sent: Tuesday, May 14, 2013 12:09 PM
> To: bob.liu@...cle.com; dan.magenheimer@...cle.com; linux-kernel@...r.kernel.org; akpm@...ux-
> foundation.org; linux-mm@...ck.org; xen-devel@...ts.xensource.com
> Subject: [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver
> (v2).
> 
> Heya,
> 
> These nine patches fix the tmem driver to:
>  - not emit a compile warning anymore (reported by 0 day test compile tool)
>  - remove the various nofrontswap, nocleancache, noselfshrinking, noselfballooning,
>    selfballooning, selfshrinking bootup options.
>  - said options are now folded in the tmem driver as module options and are
>    much shorter (and also there are only four of them now).
>  - add documentation to explain these parameters in kernel-parameters.txt
>  - And lastly add some logic to not enable selfshrinking and selfballooning
>    if frontswap functionality is off.
> 
> That is it. Tested and ready to go. If nobody objects will put on my queue
> for Linus on Monday.

FWIW, I've scanned all of these and they look sane and good.  So consider all:

Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>
 
>  Documentation/kernel-parameters.txt |   21 ++++++++
>  drivers/xen/Kconfig                 |    7 +--
>  drivers/xen/tmem.c                  |   87 ++++++++++++++++-------------------
>  drivers/xen/xen-selfballoon.c       |   47 ++----------------
>  4 files changed, 69 insertions(+), 93 deletions(-)
> 
> (oh nice, more deletions!)
> 
> Konrad Rzeszutek Wilk (9):
>       xen/tmem: Cleanup. Remove the parts that say temporary.
>       xen/tmem: Move all of the boot and module parameters to the top of the file.
>       xen/tmem: Split out the different module/boot options.
>       xen/tmem: Fix compile warning.
>       xen/tmem: s/disable_// and change the logic.
>       xen/tmem: Remove the boot options and fold them in the tmem.X parameters.
>       xen/tmem: Remove the usage of 'noselfshrink' and use 'tmem.selfshrink' bool instead.
>       xen/tmem: Remove the usage of '[no|]selfballoon' and use 'tmem.selfballooning' bool instead.
>       xen/tmem: Don't use self[ballooning|shrinking] if frontswap is off.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/