linux-kernel - Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 21:10:51 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Zhouping Liu <sanweidaying@...il.com>
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Zhouping Liu <zliu@...hat.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Matt Mackall <mpm@...enic.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'

On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu <sanweidaying@...il.com> wrote:
> From: Zhouping Liu <zliu@...hat.com>
>
> commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc())
> forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
>
> Signed-off-by: Zhouping Liu <zliu@...hat.com>
> ---
>  mm/slab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 8ccd296..8efb5f7 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3339,7 +3339,7 @@ done:
>  }
>
>  /**
> - * kmem_cache_alloc_node - Allocate an object on the specified node
> + * slab_alloc_node - Allocate an object on the specified node
>   * @cachep: The cache to allocate from.
>   * @flags: See kmalloc().
>   * @nodeid: node number of the target node.

The point of the comment is to document kernel API and whereas
slab_alloc_node() is internal to the slab allocator. Can you please
just move it on top of kmem_cache_alloc_node() definition in the same
file?

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/