linux-kernel - [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 19:25:46 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	jason.wessel@...driver.com, anton.vorontsov@...aro.org,
	sasha.levin@...cle.com, vincent.stehle@...oste.net,
	john.blackwood@...r.com
CC:	kgdb-bugreport@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.


Delete waste '{' for 'case' statement.

For the return variable 'long res' in function kdb_task_state_string(),
neither it matches the function return type 'unsigned long', nor is
suitable as a flag variable to make 'or' operation. So use 'unsigned
long' instead of 'long'.

If "case 'A'" happen in function kdb_task_state_string(), can return
~0UL directly to save the useless looping.

Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 kernel/debug/kdb/kdb_main.c    |    3 ---
 kernel/debug/kdb/kdb_support.c |    5 ++---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 00eb8f7..62a0d4a 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -1151,7 +1151,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
 
 	switch (reason) {
 	case KDB_REASON_DEBUG:
-	{
 		/*
 		 * If re-entering kdb after a single step
 		 * command, don't print the message.
@@ -1176,8 +1175,6 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
 				   db_result);
 			break;
 		}
-
-	}
 		break;
 	case KDB_REASON_ENTER:
 		if (KDB_STATE(KEYBOARD))
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index d35cc2d..75377d1 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -560,7 +560,7 @@ int kdb_putword(unsigned long addr, unsigned long word, size_t size)
 
 unsigned long kdb_task_state_string(const char *s)
 {
-	long res = 0;
+	unsigned long res = 0;
 	if (!s) {
 		s = kdbgetenv("PS");
 		if (!s)
@@ -599,8 +599,7 @@ unsigned long kdb_task_state_string(const char *s)
 			res |= DAEMON;
 			break;
 		case 'A':
-			res = ~0UL;
-			break;
+			return ~0UL;
 		default:
 			  kdb_printf("%s: unknown flag '%c' ignored\n",
 				     __func__, *s);
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/