linux-kernel - Re: [PATCH 09/15] perf ftrace: Add 'record' sub-command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 11:24:10 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 09/15] perf ftrace: Add 'record' sub-command

On Wed, 15 May 2013 23:20:52 +0200, Jiri Olsa wrote:
> On Tue, May 14, 2013 at 07:13:53PM +0900, Namhyung Kim wrote:
>> +		raw_data = synthesize_raw_data(evsel);
>> +		if (raw_data == NULL) {
>> +			pr_err("synthesizing raw sample failed\n");
>> +			goto out_fra;
>> +		}
>> +
>> +		/*
>> +		 * start of raw data is the size of raw data excluding itself.
>> +		 */
>> +		raw_size = sizeof(u32) + (*(u32 *) raw_data);
>> +
>> +		orig_size = event.sample.header.size;
>> +		event.sample.header.size += raw_size;
>> +
>> +		err = write(perf_fd, &event.sample, orig_size);
>> +		if (err != orig_size) {
>> +			pr_err("write error occurred\n");
>> +			goto out_fra;
>> +		}
>> +
>> +		err = write(perf_fd, raw_data, raw_size);
>> +		if (err != (int)raw_size) {
>> +			pr_err("write error occurred\n");
>> +			goto out_fra;
>> +		}
>
> missing free(raw_data) ?

Argh, right!

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/