linux-kernel - Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 May 2013 00:13:21 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Leon Romanovsky <leon@...n.nu>
Cc:	sbkim73@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

Hi Leon,

On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote:
> Signed-off-by: Leon Romanovsky <leon@...n.nu>
> ---
>  drivers/mfd/sec-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 77ee26ef..5b740a3 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -121,7 +121,7 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata(
>  {
>  	struct sec_platform_data *pd;
>  
> -	pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
> +	pd = devm_kzalloc(dev, sizeof(struct sec_platform_data), GFP_KERNEL);
How is that fixing anything ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/