linux-kernel - Re: [PATCH v3] usb: ehci: Only sleep for post-resume handover if devices use persist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 17:42:31 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Julius Werner <jwerner@...omium.org>
Cc:	linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, Vincent Palatin <vpalatin@...omium.org>,
	Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH v3] usb: ehci: Only sleep for post-resume handover if
 devices use persist

On Thu, Apr 25, 2013 at 09:08:27AM -0700, Julius Werner wrote:
> The current EHCI code sleeps a flat 110ms in the resume path if there
> was a USB 1.1 device connected to its companion controller during
> suspend, waiting for the device to reappear and reset so that it can be
> handed back to the companion. This is necessary if the device uses
> persist, so that the companion controller can actually see it during its
> own resume path.
> 
> However, if the device doesn't use persist, this is entirely
> unnecessary. We might just as well ignore it and have the normal device
> detection/reset/handoff code handle it asynchronously when it eventually
> shows up. As USB 1.1 devices are almost exclusively HIDs these days (for
> which persist has no value), this can allow distros to shave another
> tenth of a second off their resume time.
> 
> In order to enable this optimization, the patch also adds a new
> usb_for_each_dev() iterator that is exported by the USB core and wraps
> bus_for_each_dev() with the logic to differentiate between struct
> usb_device and struct usb_interface on the usb_bus_type bus.
> 
> Signed-off-by: Julius Werner <jwerner@...omium.org>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> ---
>  drivers/usb/core/usb.c      | 33 +++++++++++++++++++++++++++++++++
>  drivers/usb/host/ehci-hub.c | 17 +++++++++++++++++
>  include/linux/usb.h         |  1 +
>  3 files changed, 51 insertions(+)

This patch is corrupted somehow, but I can't figure out how.

I'm getting the error:
	checking file drivers/usb/core/usb.c
	checking file drivers/usb/host/ehci-hub.c
	patch: **** malformed patch at line 164: @@ -56,6 +63,16 @@ static void ehci_handover_companion_ports(struct ehci_hcd *ehci)

when trying to apply it.  git also doesn't like it.

Care to fix this up and resend it so I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/