lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 May 2013 11:55:06 +0900 From: Jonghwan Choi <jhbird.choi@...il.com> To: Jon Mason <jon.mason@...el.com> Cc: stable@...r.kernel.org, linux-kernel@...r.kernel.org, Jonghwan Choi <jhbird.choi@...sung.com> Subject: [PATCH 3.9-stable] ntb_netdev: remove from list on exit From: Jon Mason <jon.mason@...el.com> This patch looks like it should be in the 3.9-stable tree, should we apply it? ------------------ From: "Jon Mason <jon.mason@...el.com>" commit 904435cf76a9bdd5eb41b1c4e049d5a64f3a8400 upstream The ntb_netdev device is not removed from the global list of devices upon device removal. If the device is re-added, the removal code would find the first instance and try to remove an already removed device. Cc: <stable@...r.kernel.org> # 3.9.x: ad3e2751: ntb: off by one Cc: <stable@...r.kernel.org> # 3.9.x: cc0f868d: NTB: fix pointer math Cc: <stable@...r.kernel.org> # 3.9.x: 113fc505: NTB: Handle 64bit BAR Cc: <stable@...r.kernel.org> # 3.9.x: b77b2637: NTB: Link toggle memory Cc: <stable@...r.kernel.org> # 3.9.x: 90f9e934: NTB: reset tx_index on Cc: <stable@...r.kernel.org> # 3.9.x: c9d534c8: NTB: Correctly handle receive Cc: <stable@...r.kernel.org> # 3.9.x: c336acd3: NTB: memcpy lockup workaround Signed-off-by: Jon Mason <jon.mason@...el.com> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com> --- drivers/net/ntb_netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c index ed947dd..f3cdf64 100644 --- a/drivers/net/ntb_netdev.c +++ b/drivers/net/ntb_netdev.c @@ -375,6 +375,8 @@ static void ntb_netdev_remove(struct pci_dev *pdev) if (dev == NULL) return; + list_del(&dev->list); + ndev = dev->ndev; unregister_netdev(ndev); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists