linux-kernel - [Suggestion] mm/bootmem.c: need return failure code when BUG() neither CONFIG_BUG nor HAVE_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 20 May 2013 16:10:18 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	hannes@...xchg.org, Tejun Heo <tj@...nel.org>, js1304@...il.com
CC:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: [Suggestion] mm/bootmem.c: need return failure code when BUG()  neither
 CONFIG_BUG nor HAVE_ARCH_BUG is defined.

Hello Maintainers:

If neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, the BUG() will
defined as empty (e.g. randconfig with MMU for arm s5pv210)

As a function, it need return an error code to upper caller, but excuse
me, I can not find the suitable error code for return (it seems only
'return -1' is not suitable).

Please help check, thanks.


356 static int __init mark_bootmem(unsigned long start, unsigned long end,
357                                 int reserve, int flags)
358 {
359         unsigned long pos;
360         bootmem_data_t *bdata;
361 
362         pos = start;
363         list_for_each_entry(bdata, &bdata_list, list) {
364                 int err;
365                 unsigned long max;
366 
367                 if (pos < bdata->node_min_pfn ||
368                     pos >= bdata->node_low_pfn) {
369                         BUG_ON(pos != start);
370                         continue;
371                 }
372 
373                 max = min(bdata->node_low_pfn, end);
374 
375                 err = mark_bootmem_node(bdata, pos, max, reserve, flags);
376                 if (reserve && err) {
377                         mark_bootmem(start, pos, 0, 0);
378                         return err;
379                 }
380 
381                 if (max == end)
382                         return 0;
383                 pos = bdata->node_low_pfn;
384         }
385         BUG();
386 }



Thanks.
-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/