linux-kernel - Re: The dd72be99 breaks some of Intel Medfield based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 May 2013 10:36:30 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Bin Gao <bin.gao@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: The dd72be99 breaks some of Intel Medfield based devices

[+cc linux-pci and cc list of Bin's original posting]

On Mon, May 20, 2013 at 9:09 AM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> Hi!
>
> I don't know what you trying to fix, but your patch dd72be99
> "x86/pci/mrst: Use configuration mechanism 1 for 00:00.0, 00:02.0,
> 00:03.0" breaks Intel Medfield devices.
>
> After it was applied (sorry, was on vacation, didn't noticed sooner)
> lspci shows only 18 out of 34 devices. That means the so called fake
> PCI devices are gone.
>
> This is a bad approach and patch should be reverted. Bin, please,
> explain what you are trying to fix and on what device. We will find
> better solution.

I reverted dd72be99 in my for-linus branch.  I guess I should have let
that sit in -next for a cycle before asking Linus to pull it.  Sorry
about jumping the gun.

I'll wait for a patch tested by both Bin and Andy.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/