linux-kernel - RE: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 May 2013 11:27:01 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Ryan Mallon <rmallon@...il.com>,
	"mcrapet@...il.com" <mcrapet@...il.com>
Subject: RE: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to
 PWM framework

On Monday, May 27, 2013 8:20 AM, Arnd Bergmann wrote:
> On Saturday 25 May 2013, H Hartley Sweeten wrote:
>> This driver needs to be converted to the new PWM framework.
>>
>> Before converting it clean up all the cruft,
>>
>> H Hartley Sweeten (14):
>>   misc/ep93xx_pwm: use managed device resources
>>   misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io
>>   misc/ep93xx_pwm: remove ep93xx_pwm_{write,read}l() inline functions
>>   misc/ep93xx_pwm: remove ep93xx_pwm_write_tc() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_write_dc() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_enable() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_disable() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_invert() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_normal() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_read_tc() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_is_enabled() inline function
>>   misc/ep93xx_pwm: remove ep93xx_pwm_is_inverted() inline function
>>   misc/ep93xx_pwm: use module_platform_driver()
>>   misc/ep93xx_pwm: use kstrtol instead of strict_strtol
>
> Whole series:
>
> Acked-by: Arnd Bergmann arnd@...db.de

Arnd,

Ryan Mallon has also provided a Reviewed-by for this series.

Will you be the one that merges this? I would like it to be in linux-next
before I convert it to the PWM framework.

Also, I have a question about the conversion.

If I strip the sysfs support out of this driver the conversion is quite simple.
But, my use for this driver requires user space control of the PWM.

Should I:
1) convert the driver to the PWM framework and leave the sysfs stuff in it
2) work out a generic sysfs support for the PWM framework and then
    convert the driver
3) other...

I've been looking at 2) by doing something like how gpiolib does it. Do
you think that would be acceptable?

Thanks,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/