linux-kernel - Re: [PATCH 1/4] MN10300: Fix ret_from_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 May 2013 10:06:57 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, linux-am33-list@...hat.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ken Cox <jkc@...hat.com>
Subject: Re: [PATCH 1/4] MN10300: Fix ret_from_kernel_thread

What kernel version are these patches against?

You explicitly mention commit ddf23e87a804, but the patch contains
ret_from_kernel_execve that was *removed* by that commit.

So the whole thing seems very confused. I'm dropping this series.

              Linus

On Tue, May 28, 2013 at 7:34 AM, David Howells <dhowells@...hat.com> wrote:
> ret_from_kernel_thread needs to set A2 to the thread_info pointer before
> jumping to syscall_exit.
>
> Without this, we never correctly start userspace.
>
> This was caused by the rejuggling of the fork/exec paths in commit:
>
>         ddf23e87a804cbf6fa3818076b33fe023cce09fd
>         Author: Al Viro <viro@...iv.linux.org.uk>
>         Date:   Thu Oct 11 17:32:41 2012 -0400
>         Subject: mn10300: switch to saner kernel_execve() semantics
>
> Reported-by: Ken Cox <jkc@...hat.com>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Acked-by: Ken Cox <jkc@...hat.com>
> Acked-by: Al Viro <viro@...IV.linux.org.uk>
> ---
>
>  arch/mn10300/kernel/entry.S |    1 +
>  1 file changed, 1 insertion(+)
>
>
> diff --git a/arch/mn10300/kernel/entry.S b/arch/mn10300/kernel/entry.S
> index 0c631d3..92c3eea 100644
> --- a/arch/mn10300/kernel/entry.S
> +++ b/arch/mn10300/kernel/entry.S
> @@ -60,6 +60,7 @@ ENTRY(ret_from_kernel_thread)
>         mov     (REG_D0,fp),d0
>         mov     (REG_A0,fp),a0
>         calls   (a0)
> +       GET_THREAD_INFO a2              # A2 must be set on return from sys_exit()
>         jmp     sys_exit
>
>  ENTRY(ret_from_kernel_execve)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/