linux-kernel - Re: [PATCH 1/2] i2c: omap: convert to module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Jun 2013 13:59:31 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	"Ben Dooks \(embedded platforms\)" <ben-linux@...ff.org>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	<linux-omap@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver()

Grygorii Strashko <grygorii.strashko@...com> writes:

> The OMAP I2C driver has a relation to pinctrl-single driver. As result,
> its probe will be deferred during system boot until late init time,
> because the pinctrl-single is initizalized as moudle/device init time.
> This, in turn, will delay initialization of all I2C devices (like mfd,
> I2C regulators and etc.) and cause boot delay (more over, it can broken
> initialization of drivers which are not ready to use deferred probe
> mechanism yet, for example DSS).
>
> There are no sense to keep OMAP I2C initialization on subsys init layer
> any more, hence shift it to module/device layer where the i2c <-->
> pinctrl-single dependency is resolved in drivers/Makefile now.
>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: "Ben Dooks (embedded platforms)" <ben-linux@...ff.org>
> Cc: Santosh Shilimkar <santosh.shilimkar@...com>
> Cc: linux-omap@...r.kernel.org
> Cc: linux-i2c@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Testing this patch with PATCH 1/2, the twl_rtc driver fails to correctly
initialize on OMAP3:

         twl_rtc rtc.22: hctosys: invalid date/time

instead of the expected result:

          twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)

so something is still not right for the init sequence.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/