linux-kernel - [PATCH 0/6] keucr: checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  5 Jun 2013 10:50:00 +0200
From:	Johannes Schilling <of82ecuq@....cs.fau.de>
To:	linux-kernel@...r.kernel.org
Cc:	linux-kernel@...cs.fau.de, Al Cho <acho@...ell.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Kurt Kanzenbach <shifty91@...il.com>,
	devel@...verdev.osuosl.org,
	Johannes Schilling <of82ecuq@....cs.fau.de>,
	Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: [PATCH 0/6] keucr: checkpatch fixes

hi,

we started cleaning up a bit in drivers/staging/keucr, resolved a lot of
checkpatch warnings and errors.

[PATCH 1/6] keucr: remove some unneccesary typedefs

in ../init.c the two unused typedefed structures ADDRESS_T and SSFDCTYPE_T are
removed, in other files typedefs are removed and replaced with actual
structures and pointers.

[PATCH 2/6] keucr: fix some camelCase warnings

still a lot of camelCase to go, but this is a start. checkpatch.pl is mostly
satisfied with the progress.

[PATCH 3/6] migrate printk to dev_dbg/info/warn/err

printk()-calls without facility levels replaced with dev_{dbg,info,warn,err}
accordingly.

[PATCH 4/6] keucr: make error messages less aggressive

in .../keucr/smilsub.c a lot of error messages ended with "!!\n", we changed
that to a less shouting version. also, no punctuation in error messages is
probably a good thing.

[PATCH 5/6] keucr: various alignment- and whitespace-problems

line-lengths, whitespace around operators and placement of braces now as
demanded by checkpatch

[PATCH 6/6] keucr: use more specific max_t(int, ..

one more change, didn't fit in any of the other categories: change max(a, b)
to max_t(int, a, b) in .../keucr/transport.c, as suggested by checkpatch

all in all we're on a good way to get clean here, by far the biggest part that
is left is "externs should be avoided in .c files", those will need some more
careful work.

regards,
   laura lawniczak, johannes schilling

total diffstat:

Johannes Schilling (6):
  keucr: remove some unneccesary typedefs
  keucr: fix some camelCase warnings
  keucr: migrate printk to dev_dbg/info/warn/err
  keucr: make error messages less aggressive
  keucr: fix some alignment- and whitespace-problems
  keucr: use more specific max_t(int, ..

 drivers/staging/keucr/init.c      |   72 +++++++++++-----------
 drivers/staging/keucr/init.h      |    8 +--
 drivers/staging/keucr/scsiglue.c  |    7 ++-
 drivers/staging/keucr/smil.h      |   16 -----
 drivers/staging/keucr/smilmain.c  |  122 ++++++++++++++++++-------------------
 drivers/staging/keucr/smilsub.c   |   14 ++---
 drivers/staging/keucr/smscsi.c    |    6 +-
 drivers/staging/keucr/transport.c |    4 +-
 drivers/staging/keucr/usb.c       |    8 +--
 drivers/staging/keucr/usb.h       |   30 ++++-----
 10 files changed, 132 insertions(+), 155 deletions(-)

Signed-off-by: Laura Lawniczak <laura.lawniczak@...glemail.com>
Signed-off-by: Johannes Schilling <of82ecuq@....cs.fau.de> 

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/