[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 7 Jun 2013 00:48:38 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Johannes Schilling <of82ecuq@....cs.fau.de>
Cc: linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
Kurt Kanzenbach <shifty91@...il.com>,
linux-kernel@...cs.fau.de,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Al Cho <acho@...ell.com>,
Amarjargal Gundjalam <amarjargal16@...il.com>,
Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: Re: [PATCH 4/6] keucr: more readable and friendly error messages
On Thu, Jun 06, 2013 at 06:10:48PM +0200, Johannes Schilling wrote:
> @@ -71,7 +71,9 @@ int ENE_SMInit(struct us_data *us)
>
> result = ENE_LoadBinCode(us, SM_INIT_PATTERN);
> if (result != USB_STOR_XFER_GOOD) {
> - dev_info(&us->pusb_dev->dev, "Load SM Init Code Fail !!\n");
> + dev_info(&us->pusb_dev->dev,
> + "Failed to load SmartMedia init code\n: result= %x\n",
> + result);
It doens't work to put newlines in the middle of a printk(). It
has to go at the end. The reason is that dev_xxx() functions add
something to the beginning of lines.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists