linux-kernel - Re: [PATCH 1/1] keucr: restored lost line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Jun 2013 00:56:42 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Laura Lawniczak <laura.lawniczak@...glemail.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	Kurt Kanzenbach <shifty91@...il.com>,
	linux-kernel@...cs.fau.de,
	Johannes Schilling <of82ecuq@....cs.fau.de>,
	linux-kernel@...r.kernel.org, Al Cho <acho@...ell.com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>
Subject: Re: [PATCH 1/1] keucr: restored lost line

On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
> 

Oh wow...  I noticed this in the first patch and I couldn't figure
out why the blen = 0 was there...  It never occurred to me that it
was to silence the warning.  :P  That's hilarious.

The blen variable is only used in commented out code.  Don't do
this.  Please delete everything to do with blen.  It's there in the
history if anyone wants to see it.  Delete "bn" as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/