linux-kernel - Re: [PATCH v7 05/11] cpuacct: don't actually do anything.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Jun 2013 16:16:07 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Glauber Costa <glommer@...nvz.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Turner <pjt@...gle.com>, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, Frederic Weisbecker <fweisbec@...il.com>,
	devel@...nvz.org, Peter Zijlstra <peterz@...radead.org>,
	Michal Hocko <mhocko@...e.cz>,
	Kay Sievers <kay.sievers@...y.org>,
	Lennart Poettering <mzxreary@...inter.de>,
	Dave Jones <davej@...hat.com>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH v7 05/11] cpuacct: don't actually do anything.

Hello, Glauber.

I think the patch title / description are a bit confusing.  This is
about pcpuacct stats provided by cpu controller, right?

> +#ifdef CONFIG_SCHEDSTATS
> +#ifdef CONFIG_FAIR_GROUP_SCHED
...
>  #else
...
> +#endif
> +#ifdef CONFIG_RT_GROUP_SCHED
...
> +#else
...
>  #endif
...
> +#else
> +#endif

This is getting rather messy.  Maybe CONFIG_CGROUP_SCHED should just
select CONFIG_SCHEDSTATS?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/