linux-kernel - Re: [PATCH] USB: serial/ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Jun 2013 20:49:48 +0200
From:	Willy Tarreau <w@....eu>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Lotfi Manseur <lotfi.manseur@...il.com>, stable@...r.kernel.org,
	Wojciech M Zabolotny <W.Zabolotny@...a.pw.edu.pl>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Lotfi Manseur <lotfi.manseur@...g.fr>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

On Fri, Jun 07, 2013 at 10:30:09AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 07, 2013 at 03:14:32PM +0200, Lotfi Manseur wrote:
> > Handle null termios in ftdi_set_termios(), introduced in
> > commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846
> > This has been corrected in the mainline by
> > commits c515598e0f5769916c31c00392cc2bfe6af74e55 and
> > a816e3113b63753c330ca4751ea1d208e93e3015.
> 
> Then why shouldn't we just include those commit instead of your patch,
> which looks much different from these?
> 
> I'd much rather take the originals, not something else.

Indeed. I've checked, and the second commit was just cosmetic (silence
a warning reported by sparse for ptr == 0 introduced in the first one).

The context is minimally different (original commit introduces a jump
to a label whose context has changed). I tend to think that the merged
fix has less changes of being incorrectly applied, but given their
triviality we could very well merge the original ones instead, and
keep initial authorship BTW.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/