linux-kernel - Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 8 Jun 2013 19:54:30 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Paul Bolle <pebolle@...cali.nl>
cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c

On Thu, 30 May 2013, Paul Bolle wrote:

> promcon.o is built if CONFIG_PROM_CONSOLE is set. But there's no Kconfig
> symbol PROM_CONSOLE, so promcon.c is unbuildable. Remove it.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> 0) Untested.
> 
> 1) There used to be a Kconfig symbol PROM_CONSOLE. But it was SPARC
> specific and it was removed in v2.6.32, see commit 09d3f3f0e0 ("sparc:
> Kill PROM console driver.").
> 
> 2) Actually, it seems that it has never been possible to set
> PROM_CONSOLE for MIPS ever since this file was added in v2.3.9. I guess
> no-one noticed because (what seems to be) comparable functionality is
> provided in arch/mips/dec/prom/console.c.

 Yeah, I think over the years the file mostly served documentation 
purposes.  Given that we've had (as you also noticed) a working early-boot 
console available:

Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>

 Thanks for this clean-up.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/