linux-kernel - Re: [PATCH] spi: s3c64xx: Fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Jun 2013 18:10:46 +0200
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	broonie@...nsource.wolfsonmicro.com
Cc:	grant.likely@...aro.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] spi: s3c64xx: Fix pm_runtime_get_sync() return value check

On 05/27/2013 04:56 PM, Sylwester Nawrocki wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1, so a test for negative
> value should be used to check for errors.
> 
> Without this patch there are seen errors like:
> 
> [    8.540000] s3c64xx-spi 13930000.spi: Failed to enable device: 1
> [    8.545000] spi_master spi1: failed to prepare transfer hardware
> 
> Likely because the driver uses synchronous API to runtime enable
> the device and asychronous one to disable it.

Is there anything wrong with this patch ? I still can't see it in
Linus' tree.

> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  drivers/spi/spi-s3c64xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 5000586..71cc3e6 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -444,7 +444,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi)
>  	}
>  
>  	ret = pm_runtime_get_sync(&sdd->pdev->dev);
> -	if (ret != 0) {
> +	if (ret < 0) {
>  		dev_err(dev, "Failed to enable device: %d\n", ret);
>  		goto out_tx;
>  	}
> 

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/