linux-kernel - Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Jun 2013 11:03:11 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
Cc:	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>
Subject: Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

Manish,

On Mon, Jun 10, 2013 at 10:23:16AM +0000, Vishwanathrao Badarkhe, Manish wrote:
> Hi Dmitry,
> 
> On Mon, Jun 10, 2013 at 11:34:42, Dmitry Torokhov wrote:
> > Hi Manish,
> > 
> > On Tue, May 21, 2013 at 02:24:17PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> > 
> > > +	struct touchscreen_init_data *init_data = NULL;
> > > +	int err;
> > > +
> > > +	if (node)
> > > +		node = of_find_node_by_name(node, "tsc");
> > 
> > Why do you have to locate OF node manually instead of already having it attached to the device stucture?
> 
> As TPS6507x is mfd device containing two nodes, regulator and touchscreen.
> It is necessary to use "of_find_node_by_name" to find child "tsc" node of 
> TPS6507x MFD device.

I understand that TPS6507x is a MFD device, However, I still do not
understand why you do not attach OF data to the child platform device
representing touchscreen when you create it.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/