linux-kernel - Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 16:06:18 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Philip Avinash <avinashphilip@...com>
CC:	<khilman@...prootsystems.com>, <linux@....linux.org.uk>,
	<grant.likely@...retlab.ca>, <linus.walleij@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure

On 5/22/2013 12:40 PM, Philip Avinash wrote:
> From: KV Sujith <sujithkv@...com>
> 
> Add struct davinci_gpio_platform_data davinci gpio module.
> 
> Signed-off-by: KV Sujith <sujithkv@...com>
> Signed-off-by: Philip Avinash <avinashphilip@...com>

As Linus commented before, this should be merged with 03/11.

> ---
>  include/linux/platform_data/gpio-davinci.h |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 include/linux/platform_data/gpio-davinci.h
> 
> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
> new file mode 100644
> index 0000000..f1c8277
> --- /dev/null
> +++ b/include/linux/platform_data/gpio-davinci.h
> @@ -0,0 +1,27 @@
> +/*
> + * gpio-davinci.h

I would drop this unnecessary filename mention as well.

> + *
> + * DaVinci GPIO Platform Related Defines
> + *
> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARCH_DAVINCI_GPIO_H
> +#define __ASM_ARCH_DAVINCI_GPIO_H

This should now be __PLATFORM_DATA_DAVINCI_GPIO_H__ or some such since
the file as been moved out of arch specific folder.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/