linux-kernel - Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 12:00:51 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Rojhalat Ibrahim <imr@...chenk.de>
CC:	Michael Guntsche <michael.guntsche@...loops.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote:
> On Monday 10 June 2013 17:52:33 Scott Wood wrote:
> > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote:
> > > Good evening,
> > >
> > > This patch does not fix the problem, during boot the kernel still
> > > panics. I had a closer look at the commit and the following patch
> > > fixes it for me....
> > >
> > > diff --git a/arch/powerpc/sysdev/fsl_pci.c
> > > b/arch/powerpc/sysdev/fsl_pci.c
> > > index 028ac1f..21b687f 100644
> > > --- a/arch/powerpc/sysdev/fsl_pci.c
> > > +++ b/arch/powerpc/sysdev/fsl_pci.c
> > > @@ -814,7 +814,7 @@ int __init mpc83xx_add_bridge(struct  
> device_node
> > > *dev)
> > >
> > >                 if (ret)
> > >
> > >                         goto err0;
> > >
> > >         } else {
> > >
> > > -               fsl_setup_indirect_pci(hose, rsrc_cfg.start,
> > > +               setup_indirect_pci(hose, rsrc_cfg.start,
> > >
> > >                                        rsrc_cfg.start + 4, 0);
> > >
> > >         }
> >
> > The only difference here is that you're not setting hose->ops to
> > fsl_indirect_pci_ops.  Do you know why that is helping, and what
> > hose->ops is set to instead?
> >
> > -Scott
> 
> The difference is only the read function in hose->ops, which is set to
> indirect_read_config instead of fsl_indirect_read_config.
> 
> fsl_indirect_read_config calls fsl_pcie_check_link, which is where  
> the Oops
> occurs.

Why is fsl_pcie_check_link being called for non-PCIe buses?

> Mike, can you find out where exactly in fsl_pcie_check_link the bad  
> access
> happens? Enabling CONFIG_DEBUG_BUGVERBOSE might help.

Why does it matter?  You shouldn't be calling that function at all.

-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/