linux-kernel - RE: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Jun 2013 08:12:37 +0000
From:	"J, KEERTHY" <j-keerthy@...com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	"Cousson, Benoit" <b-cousson@...com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ldewangan@...dia.com" <ldewangan@...dia.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"swarren@...dia.com" <swarren@...dia.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: RE: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and regulator
 nodes



> -----Original Message-----
> From: Stephen Warren [mailto:swarren@...dotorg.org]
> Sent: Tuesday, June 11, 2013 9:32 PM
> To: J, KEERTHY
> Cc: Cousson, Benoit; devicetree-discuss@...ts.ozlabs.org; linux-
> omap@...r.kernel.org; linux-kernel@...r.kernel.org;
> ldewangan@...dia.com; grant.likely@...retlab.ca; swarren@...dia.com;
> sameo@...ux.intel.com; gg@...mlogic.co.uk; lee.jones@...aro.org
> Subject: Re: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and
> regulator nodes
> 
> On 06/10/2013 11:30 PM, J Keerthy wrote:
> > This patch adds Palmas MFD node and the regulator nodes for OMAP5.
> >
> > The node definitions are based on: https://lkml.org/lkml/2013/6/6/25
> >
> > Boot tested on omap5-uevm board.
> 
> > diff --git a/arch/arm/boot/dts/omap5-uevm.dts
> > b/arch/arm/boot/dts/omap5-uevm.dts
> 
> > +	palmas: palmas@48 {
> > +		reg = <0x48>;
> > +		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N
> */
> > +		interrupt-parent = <&gic>;
> > +	};
> > +};
> > +
> > +&palmas {
> > +	compatible = "ti,palmas";
> > +	interrupt-controller;
> > +	#interrupt-cells = <2>;
> 
> I don't really see the point of splitting the node into two parts if
> it's all going into a single file. It made sense if part of the node
> came from a common .dtsi file, but not so much when it doesn't.

The intent was to reduce indentation and to declare its sub-nodes outside
of i2c1. I will club it and resend.

Regards,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/