linux-kernel - Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Jun 2013 14:20:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cody P Schafer <cody@...ux.vnet.ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
	Valdis.Kletnieks@...edu
Subject: Re: [PATCH] mm/page_alloc: don't re-init pageset in
 zone_pcp_update()

On Tue, 11 Jun 2013 15:12:59 -0700 Cody P Schafer <cody@...ux.vnet.ibm.com> wrote:

> Factor pageset_set_high_and_batch() (which contains all needed logic too
> set a pageset's ->high and ->batch inrespective of system state) out of
> zone_pageset_init(), which avoids us calling pageset_init(), and
> unsafely blowing away a pageset at runtime (leaked pages and
> potentially some funky allocations would be the result) when memory
> hotplug is triggered.

This changelog is pretty screwed up :( It tells us what the patch does
but not why it does it.

> Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com>
> ---
> 
> Unless memory hotplug is being triggered on boot, this should *not* be cause of Valdis
> Kletnieks' reported bug in -next:
>          "next-20130607 BUG: Bad page state in process systemd pfn:127643"

And this addendum appears to hint at the info we need.

Please, send a new changelog?  That should include a description of the
user-visible effects of the bug which is being fixed, a description of
why it occurs and a description of how it was fixed.  It would also be
helpful if you can identify which kernel version(s) need the fix.

Also, a Reported-by:Valdis would be appropriate.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/