linux-kernel - Re: [checkpatch]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 21:15:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sören Brinkmann <soren.brinkmann@...inx.com>
Cc:	PINTU KUMAR <pintu_agarwal@...oo.com>,
	Andy Whitcroft <apw@...onical.com>,
	anish singh <anish198519851985@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [checkpatch] - Confusion

On Tue, 2013-06-11 at 17:54 -0700, Sören Brinkmann wrote:
> Hi Pintu,
> 
> On Mon, Jun 10, 2013 at 11:49:00AM -0700, PINTU KUMAR wrote:
> > >________________________________
> > > From: anish singh <anish198519851985@...il.com>
> > >To: PINTU KUMAR <pintu_agarwal@...oo.com> 
> > >Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>; "linux-mm@...ck.org" <linux-mm@...ck.org> 
> > >Sent: Sunday, 9 June 2013 10:58 PM
> > >Subject: Re: [checkpatch] - Confusion
> > > 
> > >
> > >On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR <pintu_agarwal@...oo.com> wrote:
> > >> Hi,
> > >>
> > >> I wanted to submit my first patch.
> > >> But I have some confusion about the /scripts/checkpatch.pl errors.
> > >>
> > >> After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors.
> > >> But when I create patches are git format-patch, it is showing me 1 error.
> > >did  you run the checkpatch.pl on the file which gets created
> > >after git format-patch?
> > >If yes, then I think it is not necessary.You can use git-am to apply
> > >your own patch on a undisturbed file and if it applies properly then
> > >you are good to go i.e. you can send your patch.
> > 
> > Yes, first I ran checkpatch directly on the file(mm/page_alloc.c) and fixed all the errors.
> > It showed me (0) errors.
> > Then I created a patch using _git format-patch_ and ran checkpatch again on the created patch.
> > But now it is showing me 1 error.
> > According to me this error is false positive (irrelevant), because I did not change anything related to the error and also the similar change already exists somewhere else too.
> > Do you mean, shall I go ahead and submit the patch with this 1 error??
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > 
> > #153: FILE: mm/page_alloc.c:5476:
> > +int min_free_kbytes_sysctl_handler(ctl_table *table, int write,
> Rather a shot into the dark, but it looks like checkpatch is
> misinterpreting 'ctl_table' as an arithmetic operand instead of a type.
> I don't know how checkpatch learns about types created by typedefs, but
> my guess is, that this line
> 	typedef struct ctl_table ctl_table; (include/linux/sysctl.h)
> is not correctly picked up by checkpatch.

checkpatch isn't a c compiler.
It assumes any <foo>_t is a typedef.

> So, I assume this actually is a false positive.

Yup.

Maybe this would work?
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..e673bec 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -264,7 +264,7 @@ our $UTF8	= qr{
 
 our $typeTypedefs = qr{(?x:
 	(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
-	atomic_t
+	atomic_t|ctl_table
 )};
 
 our $logFunctions = qr{(?x:


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/