linux-kernel - Re: [PATCH/RESEND 02/12] msm_serial: Use devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Jun 2013 10:55:25 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH/RESEND 02/12] msm_serial: Use devm_clk_get() and properly
 return errors

On Mon, Jun 17, 2013 at 10:43:09AM -0700, Stephen Boyd wrote:
> Clocks are not clk_put() in this driver's error paths during
> probe. The code that checks for clock errors also fails to
> properly return the error code from the pclk member if it turns
> out to be the failing clock, leading to potentially confusing
> error values if the clk member is not an error pointer. Fix these
> problems with devm_clk_get() and proper error checking.
> 
> Removing the clk_put() in msm_serial_remove() also points out
> that msm_port is unused. Furthermore, msm_port is the wrong type
> and so the clk_put() would be using the wrong pointer. Replace it
> with the proper type and call uart_remove_one_port() to do the
> proper cleanup.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/