| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Jun 2013 11:01:51 -0700 From: Tejun Heo <tj@...nel.org> To: Matthew Garrett <mjg@...hat.com>, Aaron Lu <aaron.lu@...el.com> Cc: Liu Jiang <liuj97@...il.com>, Liu Jiang <liu97@...il.com>, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, Liu Jiang <jiang.liu@...wei.com> Subject: Re: [PATCH] libata: remove dead code from libata-acpi.c On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote: > On 06/15/2013 11:02 AM, Liu Jiang wrote: > > From: Liu Jiang <liu97@...il.com> > > > > Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" > > removed ACPI dock notification related code, but there's some dead > > code left, so clean up it. > > I never noticed this, but it looks to be the case... > > I'm not sure the dock notification code is removed intentionally or > mistakenly though, if it is a mistake, then instead of removing the left > code here, we probably should add the dock notification code back. > > But I have no test system or any knowledge about how ata dock works, so > I may be wrong :-) Looks like a regression to me. We're probably locking up on some older laptops which connects optical drives with hotpluggable PATA. Matthew, can you please fix it? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists