linux-kernel - Re: + mm-thp-dont-use-hpage_shift-in-transparent-hugepage-code.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Jun 2013 14:29:14 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: +
 mm-thp-dont-use-hpage_shift-in-transparent-hugepage-code.patch added to -mm
 tree

On Mon, 17 Jun 2013 16:27:46 +0300 "Kirill A. Shutemov" <kirill@...temov.name> wrote:

> On Mon, May 13, 2013 at 04:14:06PM -0700, akpm@...ux-foundation.org wrote:
> > From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
> > Subject: mm/THP: don't use HPAGE_SHIFT in transparent hugepage code
> > 
> > For architectures like powerpc that support multiple explicit hugepage
> > sizes, HPAGE_SHIFT indicate the default explicit hugepage shift.  For THP
> > to work the hugepage size should be same as PMD_SIZE.  So use PMD_SHIFT
> > directly.  So move the define outside CONFIG_TRANSPARENT_HUGEPAGE #ifdef
> > because we want to use these defines in generic code with if
> > (pmd_trans_huge()) conditional.
> 
> I would propose to partly revert the patch with the patch bellow.

It's not completely clear what you're proposing here.  Can you send a
real patch against mmotm or -next for us to look at?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/