linux-kernel - Re: [PATCH 04/15] gpio_msm: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Jun 2013 11:43:20 +0530
From:	Tushar Behera <tushar.behera@...aro.org>
To:	linux-kernel@...r.kernel.org
CC:	thierry.reding@...il.com, patches@...aro.org,
	linux-gpio@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 04/15] gpio_msm: Convert to use devm_ioremap_resource

On 06/10/2013 05:05 PM, Tushar Behera wrote:
> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> introduced devm_ioremap_resource() and deprecated the use of
> devm_request_and_ioremap().
> 
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> CC: linux-gpio@...r.kernel.org
> CC: Linus Walleij <linus.walleij@...aro.org>
> CC: Grant Likely <grant.likely@...aro.org>
> ---
>  drivers/gpio/gpio-msm-v1.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
> index c798585a..c0ead43 100644
> --- a/drivers/gpio/gpio-msm-v1.c
> +++ b/drivers/gpio/gpio-msm-v1.c
> @@ -652,14 +652,14 @@ static int __devinit gpio_msm_v1_probe(struct platform_device *pdev)
>  		return irq2;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base1 = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base1)
> -		return -EADDRNOTAVAIL;
> +	base1 = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base1))
> +		return PTR_ERR(base1);
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	base2 = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base2)
> -		return -EADDRNOTAVAIL;
> +	base2 = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base2))
> +		return PTR_ERR(base2);
>  
>  	for (i = FIRST_GPIO_IRQ; i < FIRST_GPIO_IRQ + NR_GPIO_IRQS; i++) {
>  		if (i - FIRST_GPIO_IRQ >=
> 

Ping.

-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/