| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jun 2013 13:55:56 +0200 From: Paolo Bonzini <pbonzini@...hat.com> To: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> CC: gleb@...hat.com, avi.kivity@...il.com, mtosatti@...hat.com, linux-kernel@...r.kernel.org, kvm@...r.kernel.org Subject: Re: [PATCH 2/7] KVM: MMU: document clear_spte_count Il 19/06/2013 13:53, Xiao Guangrong ha scritto: > On 06/19/2013 07:32 PM, Paolo Bonzini wrote: >> Il 19/06/2013 11:09, Xiao Guangrong ha scritto: >>> Document it to Documentation/virtual/kvm/mmu.txt >> >> While reviewing the docs, I looked at the code. >> >> Why can't this happen? >> >> CPU 1: __get_spte_lockless CPU 2: __update_clear_spte_slow >> ------------------------------------------------------------------------------ >> write low >> read count >> read low >> read high >> write high >> check low and count >> update count >> >> The check passes, but CPU 1 read a "torn" SPTE. > > In this case, CPU 1 will read the "new low bits" and the "old high bits", right? > the P bit in the low bits is cleared when do __update_clear_spte_slow, i.e, it is > not present, so the whole value is ignored. Indeed that's what the comment says, too. But then why do we need the count at all? The spte that is read is exactly the same before and after the count is updated. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists