linux-kernel - Re: [PATCH v3 06/10] ARM:stixxxx: Add DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jun 2013 07:50:51 +0100
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Rob Landley <rob@...dley.net>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Russell King <linux@....linux.org.uk>,
	Stuart Menefy <stuart.menefy@...com>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	kernel@...inux.com, linux-serial@...r.kernel.org,
	Mark Brown <broonie@...nel.org>,
	Stephen Gallimore <stephen.gallimore@...com>
Subject: Re: [PATCH v3 06/10] ARM:stixxxx: Add DEBUG_LL console support

On 20/06/13 19:55, Arnd Bergmann wrote:
> On Thursday 20 June 2013, Srinivas KANDAGATLA wrote:
>> --- a/arch/arm/mach-stixxxx/board-dt.c
>> +++ b/arch/arm/mach-stixxxx/board-dt.c
>> @@ -11,6 +11,7 @@
>>  #include <linux/clocksource.h>
>>  #include <linux/irq.h>
>>  #include <asm/hardware/cache-l2x0.h>
>> +#include <asm/mach/map.h>
>>  #include <asm/mach/arch.h>
>>  
>>  #include "smp.h"
>> @@ -42,6 +43,7 @@ static const char *stih41x_dt_match[] __initdata = {
>>  };
>>  
>>  DT_MACHINE_START(STM, "STiH415/416 SoC with Flattened Device Tree")
>> +       .map_io         = debug_ll_io_init,
>>         .init_time      = stih41x_timer_init,
>>         .smp            = smp_ops(stixxxx_smp_ops),
>>         .dt_compat      = stih41x_dt_match,
> 
> This part of the patch is no longer needed, we do the same when .map_io
> is not set.

I can see the commit bc37324e "ARM: mmu: Call debug_ll_io_init if no
map_io function is specified" in arm-soc.git:for-next branch.

That makes sense to take care of this before this patch gets merged. I
will remove this line in next spin hopefully very soon.

Thanks,
srini


> 
> 	Arnd
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/