linux-kernel - Re: [PATCH] zcache: initialize module properly when zcache=FOO is given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Jun 2013 11:38:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	Michal Hocko <mhocko@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Bob Liu <lliubbo@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Cristian Rodríguez <crrodriguez@...nsuse.org>
Subject: Re: [PATCH] zcache: initialize module properly when zcache=FOO is
 given

On Wed, Jun 26, 2013 at 11:01:16AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 26, 2013 at 04:49:02PM +0200, Michal Hocko wrote:
> > 835f2f51 (staging: zcache: enable zcache to be built/loaded as a module)
> > introduced in 3.10-rc1 has introduced a bug for zcache=FOO module
> > parameter processing.
> > 
> > zcache_comp_init return code doesn't agree with crypto_has_comp which
> > uses 1 for the success unlike zcache_comp_init which uses 0. This
> > causes module loading failure even if the given algorithm is supported:
> > [    0.815330] zcache: compressor initialization failed
> > 
> > Reported-by: Cristian Rodríguez <crrodriguez@...nsuse.org>
> > Signed-off-by: Michal Hocko <mhocko@...e.cz>
> 
> Looks OK to me.
> 
> Cc-ing Greg.

That's nice, but can someone resend it in a format that I can apply it
in, with your ack?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/