linux-kernel - Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Jun 2013 18:14:09 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	Arnd Bergmann <arnd@...db.de>, Will Deacon <Will.Deacon@....com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-m32r-ja@...linux-m32r.org" <linux-m32r-ja@...linux-m32r.org>,
	"linux-m32r@...linux-m32r.org" <linux-m32r@...linux-m32r.org>
Subject: Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"

On 06/27/2013 04:29 PM, Catalin Marinas wrote:
> On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
>> > If an architecture need "generic pci.h", it also need generic "pci-dma-
>> > compat.h",  so recommend to include it in asm-generic directly.
>> > 
>> > And now, for arm64 and m32r, may cause compiling error about it.
>> > 
>> > The related error (with allmodconfig):
>> > 
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>> >   drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> >   cc1: some warnings being treated as errors
>> > 
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
> From the arm64 perspective:
> 
> Acked-by: Catalin Marinas <catalin.marinas@....com>
> 

Thanks.

> (but make sure it doesn't break other archs)

I will try to check all related archs with allmodconfig (which can also
find more another patches, and can let me familiar the compiler step by
step).  ;-)


Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/