linux-kernel - RE: [PATCH 1/1] scsi/megaraid: minor cut and paste error fixed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Jun 2013 11:22:26 +0530
From:	"Saxena, Sumit" <Sumit.Saxena@....com>
To:	James Georgas <soulpa7ch@...il.com>,
	DL-MegaRAID Linux <megaraidlinux@....com>,
	"JBottomley@...allels.com" <JBottomley@...allels.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH 1/1] scsi/megaraid: minor cut and paste error fixed.

Thanks James for pointing this out, there is no harm with this change.

Acked-by: Sumit Saxena <sumit.saxena@....com>

Sumit

>-----Original Message-----
>From: James Georgas [mailto:soulpa7ch@...il.com]
>Sent: Wednesday, June 26, 2013 11:33 PM
>To: DL-MegaRAID Linux; JBottomley@...allels.com
>Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; James
>Georgas
>Subject: [PATCH 1/1] scsi/megaraid: minor cut and paste error fixed.
>
>This looks like a cut and paste typo to me. Both of the
>megasas_read_fw_status_reg_* functions involved are identical though, so
>there was no bad behaviour. I changed it for consistency and clarity.
>
>Signed-off-by: James Georgas <soulpa7ch@...il.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 3a9ddae..87591cd 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -583,7 +583,7 @@ megasas_clear_intr_skinny(struct
>megasas_register_set __iomem *regs)
> 	/*
> 	 * Check if it is our interrupt
> 	 */
>-	if ((megasas_read_fw_status_reg_gen2(regs) & MFI_STATE_MASK) ==
>+	if ((megasas_read_fw_status_reg_skinny(regs) & MFI_STATE_MASK) ==
> 	    MFI_STATE_FAULT) {
> 		mfiStatus = MFI_INTR_FLAG_FIRMWARE_STATE_CHANGE;
> 	} else
>--
>1.8.1.5
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/