linux-kernel - Re: [RESEND][PATCH] cyttsp: Fix swap of mfg_stat and mfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 30 Jun 2013 02:32:10 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Matthias Kaehlcke <matthias.list@...hlcke.net>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Kevin McNeely <kev@...ress.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers

On Sat, Jun 29, 2013 at 6:53 PM, Matthias Kaehlcke
<matthias.list@...hlcke.net> wrote:
> The command and status register in the driver were swapped with
> respect to the order specified in the datasheet (CY8CTMA140).
> Confirmed with Cypress that the order in the datasheet is correct.
>
> Signed-off-by: Matthias Kaehlcke <matthias@...hlcke.net>
> Acked-by: Javier Martinez Canillas <javier@...hile0.org>
> Acked-by: Ferruh Yigit <fery@...ress.com>
>
> ---
>  drivers/input/touchscreen/cyttsp_core.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h
> index 1aa3c69..f1ebde3 100644
> --- a/drivers/input/touchscreen/cyttsp_core.h
> +++ b/drivers/input/touchscreen/cyttsp_core.h
> @@ -67,8 +67,8 @@ struct cyttsp_xydata {
>  /* TTSP System Information interface definition */
>  struct cyttsp_sysinfo_data {
>         u8 hst_mode;
> -       u8 mfg_cmd;
>         u8 mfg_stat;
> +       u8 mfg_cmd;
>         u8 cid[3];
>         u8 tt_undef1;
>         u8 uid[8];
> --
> 1.7.10.4
>
> --

Hi Matthias,

This patch has already been merged in Linus tree a few days ago with
commit ID d3bf073aa.

Thanks a lot and best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/