linux-kernel - RE: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Jul 2013 06:11:01 +0000
From:	"Hebbar, Gururaja" <gururaja.hebbar@...com>
To:	"Nori, Sekhar" <nsekhar@...com>
CC:	"khilman@...aro.org" <khilman@...aro.org>,
	"tony@...mide.com" <tony@...mide.com>,
	"Cousson, Benoit" <b-cousson@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Bedia, Vaibhav" <vaibhav.bedia@...com>,
	"Rajashekhara, Sudhakar" <sudhakar.raj@...com>,
	"Grant Likely" <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	"Rob Landley" <rob@...dley.net>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: RE: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events

On Tue, Jul 02, 2013 at 11:39:28, Nori, Sekhar wrote:
> On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote:
> > On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote:
> >> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote:
> >>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN)
> >>> is available to enable Alarm Wakeup feature. This register needs to be
> >>> properly handled for the rtcwake to work properly.
> >>>
> >>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt
> >>> compatibility node.
> >>>
> >>> Signed-off-by: Hebbar Gururaja <gururaja.hebbar@...com>
> >>> Cc: Grant Likely <grant.likely@...aro.org>
> >>> Cc: Rob Herring <rob.herring@...xeda.com>
> >>> Cc: Rob Landley <rob@...dley.net>
> >>> Cc: Sekhar Nori <nsekhar@...com>
> >>> Cc: Kevin Hilman <khilman@...aro.org>
> >>> Cc: Alessandro Zummo <a.zummo@...ertech.it>
> >>> Cc: rtc-linux@...glegroups.com
> >>> Cc: devicetree-discuss@...ts.ozlabs.org
> >>> Cc: linux-doc@...r.kernel.org
> >>> ---
> >>
> >> [...]
> >>
> >>> -#define	OMAP_RTC_DATA_DA830_IDX	1
> >>> +#define	OMAP_RTC_DATA_DA830_IDX		1
> >>> +#define	OMAP_RTC_DATA_AM335X_IDX	2
> >>>  
> >>>  static struct platform_device_id omap_rtc_devtype[] = {
> >>>  	{
> >>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = {
> >>>  	}, {
> >>>  		.name	= "da830-rtc",
> >>>  		.driver_data = OMAP_RTC_HAS_KICKER,
> >>> +	}, {
> >>> +		.name	= "am335x-rtc",
> >>
> >> may be use am3352-rtc here just to keep the platform device name and of
> >> compatible in sync.
> > 
> > Correct. I will update the same in v2.
> > 
> >>
> >>> +		.driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN,
> >>>  	},
> >>>  	{},
> >>
> >> It is better to use the index defined above in the static initialization
> >> so they remain in sync.
> > 
> > Sorry. I didn’t get this.
> > 
> 
> See example below I provided. If its still not clear, let me know what
> is not clear.
> 
> >> 	...
> >> 	[OMAP_RTC_DATA_DA830_IDX] = {
> >> 		.name	= "da830-rtc",
> >> 		.driver_data = OMAP_RTC_HAS_KICKER,
> >> 	},

Thanks for the clarification. In this case will it ok if I update the previous
member also.

> 
> Thanks,
> Sekhar
> 


Regards, 
Gururaja