linux-kernel - RE: [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 1 Jul 2013 22:33:13 -0700
From:	Bing Zhao <bzhao@...vell.com>
To:	Harvey Yang <harvey.huawei.yang@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt
 frame

Hi Harvey,

> From: Huawei Yang <harvey.huawei.yang@...il.com>
> 
> In function 'mwifiex_write_data_complete' it need tx info to find the
> mwifiex_private to updates statistics and wake up tx queues.
> Or we may trigger tx queues timeout when transmitting lots of mgmt frames.
> 
> Signed-off-by: Huawei Yang <harvey.huawei.yang@...il.com>
> ---
>  drivers/net/wireless/mwifiex/cfg80211.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/wireless/mwifiex/cfg80211.c
> b/drivers/net/wireless/mwifiex/cfg80211.c
> index e42b266..b4e2538 100644
> --- a/drivers/net/wireless/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> @@ -186,6 +186,7 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
>  	struct sk_buff *skb;
>  	u16 pkt_len;
>  	const struct ieee80211_mgmt *mgmt;
> +	struct mwifiex_txinfo *tx_info;
>  	struct mwifiex_private *priv = mwifiex_netdev_get_priv(wdev-
> >netdev);
> 
>  	if (!buf || !len) {
> @@ -212,6 +213,10 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
>  		wiphy_err(wiphy, "allocate skb failed for management
> frame\n");
>  		return -ENOMEM;
>  	}
> +

Here checkpatch.pl script reports whitespace damaged error.
I can fix it in my local tree and resend v3 to John after the 3.11 merge window.

Thanks,
Bing

> +	tx_info = MWIFIEX_SKB_TXCB(skb);
> +	tx_info->bss_num = priv->bss_num;
> +	tx_info->bss_type = priv->bss_type;
> 
>  	mwifiex_form_mgmt_frame(skb, buf, len);
>  	mwifiex_queue_tx_pkt(priv, skb);
> --
> 1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/