linux-kernel - Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Jul 2013 12:45:42 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Eric Van Hensbergen <ericvh@...il.com>,
	Jim Garlick <garlick@...l.gov>,
	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where
 possible

On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote:
> On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote:
> > In long run I'd like to disable
> > the check types that tend to have false positives.  As for now, these
> > checks are disabled in my checkpatch robot:
> 
> Are you using a .checkpatch.conf file?

Nope.

> > PATCH_PREFIX
> > LONG_LINE
> > CAMELCASE
> 
> That's a --strict test

Yes. The CAMELCASE checks are false positives for the USB subsystem.
Where they followed the USB spec and use names like bInterfaceClass
all over the places.

> > MISSING_SIGN_OFF
> 
> Why would you even consider this one?

It produces

        ERROR: Missing Signed-off-by: line(s)

on
        commit: 8bb495e3f02401ee6f76d1b1d77f3ac9f079e376 Linux 3.10

        tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git master
        commit: 97966e7ec944580bc3f46712f34ecb3c854fdd4b [37/81] Revert "ALSA: hda - Fix wrong power setup for HP paths of VIA codecs"

        tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git master
        head:   120b1922175789a8a9bdafb7ea755fc63de2f392
        commit: 10296279acc5d3caeca7b2cfde329c8280fe67e5 [32/81] Merge branch 'for-linus'

and many other commits

> > COMPLEX_MACRO
> > BRACES
> > SPACING
> > LONG_LINE
> 
> OK by me.
> 
> > REDUNDANT_CODE
> 
> Also a --strict test
> 
> > TRAILING_STATEMENTS
> 
> False positives?  Got an example?

tree:   git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next
head:   d2989b534ef6834ebf2425aecc040b894b567c91
commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc, not externally

ERROR: trailing statements should be on next line
#28: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:146:
+       case NVDEV_ENGINE_GR   : addr = 0x0210; break;

ERROR: trailing statements should be on next line
#40: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:183:
+       case NVDEV_ENGINE_COPY2: addr = 0x0000; break;

ERROR: trailing statements should be on next line
#41: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:184:
+       case NVDEV_ENGINE_GR   : addr = 0x0210; break;
 
> > UNCOMMENTED_DEFINITION

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/