linux-kernel - Re: [PATCH 1/3] drm/edid: Fix constness warning in drm_load_edid_firmware()

Open Source and information security mailing list archives

Date:	Wed, 10 Jul 2013 09:23:33 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/3] drm/edid: Fix constness warning in drm_load_edid_firmware()

On Wed, Jul 10, 2013 at 7:16 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> drivers/gpu/drm/drm_edid_load.c: In function ‘drm_load_edid_firmware’:
> drivers/gpu/drm/drm_edid_load.c:245: warning: initialization discards qualifiers from pointer target type
>
> drm_get_connector_name() returns a "const char *", hence propagate the
> const where needed.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

For the series:

Reviewed-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/drm_edid_load.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c
> index a4f5ce1..2c2803f 100644
> --- a/drivers/gpu/drm/drm_edid_load.c
> +++ b/drivers/gpu/drm/drm_edid_load.c
> @@ -134,7 +134,7 @@ static u8 generic_edid[GENERIC_EDIDS][128] = {
>  };
>
>  static u8 *edid_load(struct drm_connector *connector, char *name,
> -                       char *connector_name)
> +                       const char *connector_name)
>  {
>         const struct firmware *fw;
>         struct platform_device *pdev;
> @@ -242,7 +242,7 @@ out:
>
>  int drm_load_edid_firmware(struct drm_connector *connector)
>  {
> -       char *connector_name = drm_get_connector_name(connector);
> +       const char *connector_name = drm_get_connector_name(connector);
>         char *edidname = edid_firmware, *last, *colon;
>         int ret;
>         struct edid *edid;
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives