linux-kernel - Re: [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Jul 2013 21:51:59 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq_putc()
 where possible

On Fri, 2013-07-19 at 09:40 +0800, zhangwei(Jovi) wrote:
> On 2013/7/19 9:29, Steven Rostedt wrote:
> > On Mon, 2013-07-15 at 16:32 +0800, zhangwei(Jovi) wrote:
> >> diff --git a/kernel/trace/trace_functions_graph.c
> >> b/kernel/trace/trace_functions_graph.c
> >> index 8388bc9..3793f90 100644
> >> --- a/kernel/trace/trace_functions_graph.c
> >> +++ b/kernel/trace/trace_functions_graph.c
> >> @@ -446,7 +446,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
> >>
> >>         /* First spaces to align center */
> >>         for (i = 0; i < spaces / 2; i++) {
> >> -               ret = trace_seq_printf(s, " ");
> >> +               ret = trace_seq_putc(s, ' ');
> >>                 if (!ret)
> >>                         return TRACE_TYPE_PARTIAL_LINE;
> >>         }
> >> @@ -457,7 +457,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
> >>
> >>         /* Last spaces to align center */
> >>         for (i = 0; i < spaces - (spaces / 2); i++) {
> >> -               ret = trace_seq_printf(s, " ");
> >> +               ret = trace_seq_putc(s, " ");
> > 
> > Oops, s/"/'/g
> > 
> > I'll fix it.
> > 
> Sorry for this, I will open my eyes more larger next time.
> 

Honest mistake. My tests caught it, as ktest will fail a test if a patch
causes a new warning to appear.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/