linux-kernel - Re: [PATCH] pinctrl: pinmux: Don't free pins requested by other devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 23 Jul 2013 15:34:09 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Steven Miao <realmz6@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] pinctrl: pinmux: Don't free pins requested by other devices

Ping

On Wed, Jul 17, 2013 at 1:31 PM, Sonic Zhang <sonic.adi@...il.com> wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
>
> in pinmux_disable_setting after current device fails to request
> the same pins.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> ---
>  drivers/pinctrl/pinmux.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> index 88cc509..9ebcf3b 100644
> --- a/drivers/pinctrl/pinmux.c
> +++ b/drivers/pinctrl/pinmux.c
> @@ -482,13 +482,14 @@ void pinmux_disable_setting(struct pinctrl_setting const *setting)
>                                  pins[i]);
>                         continue;
>                 }
> +               /* And release the pins */
> +               if (desc->mux_usecount &&
> +                       !strcmp(desc->mux_owner, setting->dev_name))
> +                       pin_free(pctldev, pins[i], NULL);
> +
>                 desc->mux_setting = NULL;
>         }
>
> -       /* And release the pins */
> -       for (i = 0; i < num_pins; i++)
> -               pin_free(pctldev, pins[i], NULL);
> -
>         if (ops->disable)
>                 ops->disable(pctldev, setting->data.mux.func, setting->data.mux.group);
>  }
> --
> 1.8.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/